From 4b9ae239d626e0779bfda319c31fd0e62282fa0c Mon Sep 17 00:00:00 2001
From: Matteo Cominetti <matteo@speckle.systems>
Date: Thu, 2 May 2024 09:50:06 +0100
Subject: [PATCH] fix(revit): exclude element params which are not visible
 (#3332)

---
 .../ConverterRevit/ConverterRevitShared/ConversionUtils.cs | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Objects/Converters/ConverterRevit/ConverterRevitShared/ConversionUtils.cs b/Objects/Converters/ConverterRevit/ConverterRevitShared/ConversionUtils.cs
index 49f4e09c6b..5aae514f7a 100644
--- a/Objects/Converters/ConverterRevit/ConverterRevitShared/ConversionUtils.cs
+++ b/Objects/Converters/ConverterRevit/ConverterRevitShared/ConversionUtils.cs
@@ -333,6 +333,13 @@ private void AddElementParamsToDict(
         continue;
       }
 
+      //ignore parameters that are not visible by the end users
+      //these could be set by plugins, and historically have conflited with our send operation
+      if (param.Definition is InternalDefinition internalDef && !internalDef.Visible)
+      {
+        continue;
+      }
+
       var speckleParam = ParameterToSpeckle(param, internalName, isTypeParameter);
       paramDict[internalName] = speckleParam;
     }