From ca5922cb80ff516f42ba8c07be0fe375b2b83767 Mon Sep 17 00:00:00 2001
From: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
Date: Thu, 30 May 2024 15:17:34 +0100
Subject: [PATCH] Promoted several analysers to warnings for DUI3 (#3454)

* Promoted several warnings out of `NoWarn`

* accidental CS9057
---
 Core/Core/Core.csproj                                       | 4 ++--
 DUI3-DX/DUI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs | 2 ++
 Directory.Build.props                                       | 3 +--
 Directory.Build.targets                                     | 2 +-
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/Core/Core/Core.csproj b/Core/Core/Core.csproj
index 15bac62d5a..275dcc12cc 100644
--- a/Core/Core/Core.csproj
+++ b/Core/Core/Core.csproj
@@ -23,7 +23,7 @@
       CA1502; CA1506;
       CA1708; CA1710; CA1711; CA1716; CA1720; CA1721; CA1724;
       CA1816; CA1851; CA1861;
-      CA2201; CS8618;
+      CA2201; CS8618; CA1054;
       CS0419; CS0618; CS0659; CS0809;
       CS8600; CS8602; CS8603; CS8604;
       IDE0032; IDE0059; IDE0130; IDE1006;
@@ -68,4 +68,4 @@
     <Exec Command="dotnet husky install" StandardOutputImportance="Low"
       StandardErrorImportance="High" WorkingDirectory="$(RepositoryRoot)"/>
   </Target>
-</Project>
\ No newline at end of file
+</Project>
diff --git a/DUI3-DX/DUI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs b/DUI3-DX/DUI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs
index ba25335a97..e1a434eab8 100644
--- a/DUI3-DX/DUI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs
+++ b/DUI3-DX/DUI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs
@@ -5,6 +5,7 @@
 using Speckle.Connectors.DUI.Bindings;
 using System.Threading.Tasks.Dataflow;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using Microsoft.Extensions.Logging;
 using Speckle.Connectors.Utils;
 using Speckle.Core.Models.Extensions;
@@ -306,6 +307,7 @@ public void ShowDevTools()
     ShowDevToolsAction?.Invoke();
   }
 
+  [SuppressMessage("Design", "CA1054:URI-like parameters should not be strings", Justification = "Url run as process")]
   public void OpenUrl(string url)
   {
     Process.Start(new ProcessStartInfo { FileName = url, UseShellExecute = true });
diff --git a/Directory.Build.props b/Directory.Build.props
index cc6e4ea861..a092bcd468 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -36,9 +36,8 @@
       CS1591;CS1573;
       <!-- Globalization rules -->
       CA1303;CA1304;CA1305;CA1307;CA1308;CA1309;CA1310;CA1311;CA2101;
-      NU1701;
       <!--Others we don't want-->
-      CA1815;CA1054;CA1852;CA1812;CA1003;CA2109;CA1848;$(NoWarn)
+      CA1815;CA1852;CA1812;CA1003;CA2109;CA1848;$(NoWarn)
     </NoWarn>
     
     <WarningsAsErrors>
diff --git a/Directory.Build.targets b/Directory.Build.targets
index 74264cc54f..92df7ec0f3 100644
--- a/Directory.Build.targets
+++ b/Directory.Build.targets
@@ -66,7 +66,7 @@
       CS0618;CA1034;CA2201;CA1051;CA1040;CA1724;
       IDE0044;IDE0130;CA1508;
       <!-- Analysers that provide no tangeable value to a test project -->
-      CA5394;CA2007;CA1852;CA1819;CA1711;CA1063;CA1816;CA2234;
+      CA5394;CA2007;CA1852;CA1819;CA1711;CA1063;CA1816;CA2234;CA1054;
     </NoWarn>
     <EnforceCodeStyleInBuild>false</EnforceCodeStyleInBuild>
   </PropertyGroup>