Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Updating ceilings received into Revit #3010

Open
5 tasks done
dtnaughton opened this issue Oct 27, 2023 · 1 comment
Open
5 tasks done

Enhancement: Updating ceilings received into Revit #3010

dtnaughton opened this issue Oct 27, 2023 · 1 comment
Labels
enhancement New feature or request revit issues related to the revit connector.

Comments

@dtnaughton
Copy link
Contributor

Submitting this is an enhancement as opposed to a bug, as the current intent of behaviour seems deliberate.

Prerequisites

What package are you referring to?

2.16, ConverterRevit

Is your feature request related to a problem? Please describe.

The current update functionality works by deleting the existing ceiling and creating a new one. Deleting the ceiling will also delete any lighting fixtures that are hosted on this ceiling. Therefore, the updating functionality of Revit Instances does not function as intended, because the objects sitting in the streamstate cache are no longer present in the model, so the conversion method creates them as new. The new creation of the lighting fixtures causes a change of internal Revit ids and any parameters that we assigned within the model.

Describe the solution you'd like

We want receiving ceiling with hosted lighting fixtures (family instances) to support updating functionality to enable persistence of internal revit ids of lighting fixtures and parameters.

Was there a particular reason that ceilings are deleted and recreated if they are existing, rather than trying to update existing?

Additional context

Related issues or community discussions

We can share a model confidentially (as it contains some internal info r.e. families etc) to recreate this issue. Please let me know how is best to provide this.

The general steps to recreate the condition mentioned is to:

  • Send objects to Speckle
  • Delete objects out of model in preparation to receive from Speckle
  • Open new stream state
  • Receive objects
  • Receive objects again (in same streamstate) with update selected
@dtnaughton dtnaughton added the enhancement New feature or request label Oct 27, 2023
@teocomi
Copy link
Member

teocomi commented Oct 27, 2023

Thanks for the report @dtnaughton - I'm not sure the Revit API allows updating ceilings profiles.
We can look into it, but if that's not possible, I'm afraid it will not be possible to keep the IDs of hosted elements constant...

@bimgeek bimgeek added the revit issues related to the revit connector. label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request revit issues related to the revit connector.
Projects
None yet
Development

No branches or pull requests

3 participants