Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

ARC conversion wrong in some cases! #170

Closed
Eckart-S opened this issue May 10, 2018 · 2 comments
Closed

ARC conversion wrong in some cases! #170

Eckart-S opened this issue May 10, 2018 · 2 comments

Comments

@Eckart-S
Copy link

I tried to fix a very annoying issue with Arc conversion from RhinoCommon to DesignScript but I figured out that this seems to be a RhinoCommon To SpeckleCore issue instead!?

I use GH to send the following Rhino geometry (2 lines + 5 arcs) to Speckle Stream SJvCE4GAM but as you see the geometry generated from GH Receiver, RH Receiver and Dynamo Receiver is all wrong. The Arc does not start in the proper location so it could be an issue with a badly serialised plane? Most of them work but some cases (like this one) turn out bad...

image

ArcTest.zip

Can someone figure out what the problem is and if the plane is properly stored?
Lines + Arcs are the most important elements for Revit/Dynamo so not being able to trust their validity is a serious issue and should be fixed with high priority.

Thanks a lot & Best regards, Eckart

@didimitrie didimitrie added the bug label May 16, 2018
@didimitrie
Copy link
Member

potentially related to #174 but it doesn't look like it. To keep an 👁 out for both

@didimitrie didimitrie added this to the 1.0.0-beta milestone May 18, 2018
@didimitrie
Copy link
Member

I've looked things up: the problem is that those arcs have a their domain, ie: -1.041238 To 0 , and speckle doesn't take domains into account. If you flip them, everything works as expected.

Todo:
speckleworks/SpeckleSpecs#25
speckleworks/SpeckleCore#71

Then implement this in the rhino converter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants