Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Add support for all geometry types #16

Closed
didimitrie opened this issue Mar 1, 2018 · 6 comments
Closed

Add support for all geometry types #16

didimitrie opened this issue Mar 1, 2018 · 6 comments

Comments

@didimitrie
Copy link
Member

Add logics in https://github.com/speckleworks/SpeckleViewer/blob/master/src/converter/converter.js for whatever is missing. There are some todos in there already, but on top of those, there's the undocumented types that made it in the Core, for a list see speckleworks/SpeckleSpecs#4

@mswaidan
Copy link
Collaborator

Closing this. May need to create a new issue if folks want vectors displayed.

@didimitrie
Copy link
Member Author

We could do the following re vectors: check their properties and if they have an origin display them up. And we don't enforce this, we just leave it up to convention...

What do you think?

@mswaidan
Copy link
Collaborator

Sounds good. I realized this morning I closed this prematurely - still need to add annotation support. But I believe we're down to vectors & annotation in terms of unsupported objects.

@mswaidan mswaidan reopened this Mar 30, 2018
@didimitrie
Copy link
Member Author

we will add blocks to that list too once they're implemented from the rhino converter, but that should be just a for loop function at the end of the day...

@fraguada
Copy link

fraguada commented Apr 5, 2018

I can look into annotation from Rhino at least.

@mswaidan
Copy link
Collaborator

mswaidan commented Nov 9, 2018

Closing this. #74 and #75.

@mswaidan mswaidan closed this as completed Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants