Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing process is not documented and possibly broken #306

Open
Vlad-Shcherbina opened this issue Jan 5, 2025 · 1 comment
Open

Testing process is not documented and possibly broken #306

Vlad-Shcherbina opened this issue Jan 5, 2025 · 1 comment

Comments

@Vlad-Shcherbina
Copy link
Contributor

I was trying to make a minor change but couldn't get the tests running. There are no testing instructions in the README or similar places.

The CI config suggests cargo test --all-features, but this didn't work locally for me. Also noticed the CI builds are consistently failing.

Could you please document how to test this project locally during development? Adding this to the README would make it easier for potential contributors.

@oscartbeaumont
Copy link
Member

oscartbeaumont commented Jan 18, 2025

Since we broke all of the logic out of being a single crate to multiple all of the tests have been a pretty big mess. This was a shortcut we did so we could focus on the main refactor.

What needs to happen:

  • Typescript tests broken out of 'specta-test' crate onto the 'specta-typescript' crate.
  • Introduce new tests on the 'DataType' structure included as tests on the 'specta' crate.
  • Drop the 'specta-test' crate

Right now the tests can be run like 'cargo test --all-features -p specta-test' but I'm fairly sure not all of them pass because for example the Zod exporter is still a work in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants