Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sweetalert2 support? #10

Open
hoRacy opened this issue Jun 19, 2020 · 3 comments
Open

sweetalert2 support? #10

hoRacy opened this issue Jun 19, 2020 · 3 comments

Comments

@hoRacy
Copy link

hoRacy commented Jun 19, 2020

Hello.
Is a code update planned for support of SweetAlert2? (with no "icon" option, Swal.fire instead of swal(), etc.)
Thank you.

@emredipi
Copy link
Member

Hello, I actually plan a dynamic structure for newer version since I am using inertia.js now. Maybe in new version you may use whatever you want to use.

Why do you need icon option? This package is using sweet alert to ask user password with user profile image already.

@hoRacy
Copy link
Author

hoRacy commented Jun 19, 2020

Why do you need icon option? This package is using sweetalert 1 to ask user password with user profile image already.

In current master branch isauth uses "icon" from sweetalert 1 to show users avatar. In sweetalert >=2 "icon" is not exist (replaced by imageUrl), causes script stops execution.

Its all about compatibility with current version of sweetalert 2 library that I use in my projects.

When I find some free time I will try to add pull request with support of SweetAlert 2.

@emredipi
Copy link
Member

Thank you, that would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants