Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SDK) Remvoe version number from ShardContributionRequest #70

Open
v0lkan opened this issue Dec 31, 2024 · 2 comments
Open

(SDK) Remvoe version number from ShardContributionRequest #70

v0lkan opened this issue Dec 31, 2024 · 2 comments
Assignees
@abhishek44sharma
Labels
cosmetic good first issue Good for newcomers

Comments

@v0lkan
Copy link
Contributor

v0lkan commented Dec 31, 2024

ShardContributionRequest has a field called Version. It is not used and we don't need it. We can remove it.

Note that this issue requires contributions in both spike and spike-sdk-go libraries.
@v0lkan v0lkan added good first issue Good for newcomers cosmetic labels Dec 31, 2024
@abhishek44sharma
Copy link

@v0lkan assign!
MR: spiffe/spike-sdk-go#9

@v0lkan
Copy link
Contributor Author

v0lkan commented Jan 12, 2025

@abhishek44sharma all yours :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhishek44sharma abhishek44sharma

Labels
cosmetic good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@v0lkan @abhishek44sharma