Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review replacing usage of 'ant' #629

Open
hazendaz opened this issue Aug 26, 2023 · 0 comments
Open

Review replacing usage of 'ant' #629

hazendaz opened this issue Aug 26, 2023 · 0 comments
Assignees

Comments

@hazendaz
Copy link
Member

          The issue is not with Groovy per se, it is with Ant, which this mojo explicitly uses to run SpotBugs for some reason (merely using a Groovy utility to prepare the Ant usage). I filed https://github.com/apache/ant/pull/200 to deal with this upstream, though it would be better to drop the Ant dependency and either fork via `ProcessBuilder` or directly run the SpotBugs entry point class.

As far as I can tell the workaround is just to configure the mojo to fork—there is no need to set any special JVM arguments, since the System.setSecurityManager call is only used inside the Maven JVM when fork is false.

Originally posted by @jglick in #423 (comment)

@hazendaz hazendaz changed the title The issue is not with Groovy per se, it is with Ant, which this mojo explicitly uses to run SpotBugs for some reason (merely using a Groovy utility to prepare the Ant usage). I filed https://github.com/apache/ant/pull/200 to deal with this upstream, though it would be better to drop the Ant dependency and either fork via ProcessBuilder or directly run the SpotBugs entry point class. Review replacing usage of 'ant' Aug 26, 2023
@hazendaz hazendaz self-assigned this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant