Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven 3.9.9 required to build #933

Open
elharo opened this issue Nov 28, 2024 · 1 comment
Open

Maven 3.9.9 required to build #933

elharo opened this issue Nov 28, 2024 · 1 comment

Comments

@elharo
Copy link

elharo commented Nov 28, 2024

The parent pom enforcer rule requires Maven 3.9.9 to build. However, this project's pom requires 3.6.3. Either direction, these should be synced up. IMHO 3.6.3 is just fine.

Might also be worth considering whether this project should break its dependency on com.github.hazendaz:base-parent. Without a parent pom or with a parent pom in this repo, the build would be a little flatter and easier to understand and untangle.

@hazendaz
Copy link
Member

OK so what this is really saying is that maven 3.9.9 is needed to build the project but any user can use 3.6.3 to build.

At the moment I prefer to keep the parent as I wrote it and use it in many repos. I do agree though when I took over spotbugs here I left a lot of the original way the pom was implemented in place which conflicts with style, overlaps some things and is not that clear. I can work to clear that up. I originally thought @gleclaire would be more involved and originally I just needed to get spotbugs out. At that time, it was under my account at hazendaz rather than at spotbugs but at this point its 99% me so I can certainly rework things more so its at least clear how everything works. I use a very similar style at work on around 2k repos as part of my dev/ops team and its worked well for about a decade to at least hide the maven details letting developers do what they do without having to worry but i realize that also keeps many blind to how things work. So first step I'll just work to clean up the usage here so it generally matches the style I use in the base-parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants