Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed task hang up in shellInternal due to unread error pipe. #230

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fixed task hang up in shellInternal due to unread error pipe. #230

merged 2 commits into from
Nov 22, 2023

Conversation

grigorye
Copy link
Contributor

This should address #229.

@grigorye grigorye marked this pull request as draft November 20, 2023 14:02
@grigorye grigorye force-pushed the bug/shell-hangup-due-to-unread-pipe branch from 4330b9b to 0290557 Compare November 20, 2023 14:42
@grigorye @polac24
Fixed errorData generation.
62ace6a 
Co-authored-by: Bartosz Polaczyk <[email protected]>
polac24
polac24 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@polac24 polac24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If you want to land it, make it a PR and we can merge it.

@polac24 polac24 mentioned this pull request Nov 22, 2023
Open
@grigorye grigorye marked this pull request as ready for review November 22, 2023 11:55
@grigorye
Copy link
Contributor Author

grigorye commented Nov 22, 2023 •
edited
Loading

Looks good! If you want to land it, make it a PR and we can merge it.

Thanks, yeah, fixing this thing may help to avoid encountering the hangup in further iterations, if any.

@polac24
Copy link
Collaborator

polac24 commented Nov 22, 2023

thanks!

@polac24 polac24 merged commit 487a58a into spotify:master Nov 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polac24 polac24 polac24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grigorye @polac24