Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudFoundryAppDeployer should rebind SI after updating the SI when updateServiceInstance #320

Open
LittleBaiBai opened this issue Jan 21, 2020 · 2 comments

Comments

@LittleBaiBai
Copy link
Contributor

Currently in CloudFoundryAppDeployer, we rebind service instance before updating the service instance in the implementation of updateServiceInstance. The order doesn't seem right. We should write a failing test to reproduce the problem then fix the ordering.

@Override
public Mono<UpdateServiceInstanceResponse> updateServiceInstance(UpdateServiceInstanceRequest request) {
	return operationsUtils.getOperations(request.getProperties())
		.flatMap(cfOperations -> rebindServiceInstanceIfNecessary(request, cfOperations)
			.then(updateServiceInstanceIfNecessary(request, cfOperations)));
}

@royclarkson
Copy link
Member

@LittleBaiBai do you have a scenario in mind where updating a service instance will result in it being unbound?

@LittleBaiBai
Copy link
Contributor Author

@royclarkson I'm imagining a case where backing service params would influence the binding credentials that backing app receives from the backing app binding, and that's one of the reasons, if not all, why users would set rebind-on-update to true in their configuration. That's why I think we should do update before the rebind.

@royclarkson royclarkson changed the title CloudFoundryAppDeployer should rebind SI after updating the SI when updateServiceInstnace CloudFoundryAppDeployer should rebind SI after updating the SI when updateServiceInstance Apr 15, 2020
@spikymonkey spikymonkey modified the milestones: 1.1.0.M2, 1.2.0.M1 Jun 3, 2020
@spikymonkey spikymonkey modified the milestones: 1.2.0-M1, 1.2.0-M3 Jun 11, 2020
@spikymonkey spikymonkey removed the 1.2.x label Jan 14, 2021
@spikymonkey spikymonkey modified the milestones: App Broker 1.4.0-M2, App Broker 1.4.0 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants