Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test: LifecycleMvcAutoConfigurationTests.environmentWebEndpointExtensionEnabled #1362

Open
OlgaMaciaszek opened this issue Jul 15, 2024 · 3 comments
Assignees
Labels

Comments

@OlgaMaciaszek
Copy link
Collaborator

https://github.com/spring-cloud/spring-cloud-commons/actions/runs/9941908937/job/27462194088

Occured after merging: 4e6540b

@OlgaMaciaszek OlgaMaciaszek self-assigned this Jul 15, 2024
@spencergibb
Copy link
Member

I don't think it's a flaky test. After upgrading to boot 3.4 it fails consistently. The flaky nature was probably due to compatibility tests or something.

@spencergibb spencergibb added this to the 4.2.0-M1 milestone Aug 5, 2024
@spencergibb spencergibb moved this to Todo in 2024.0.0-M1 Aug 5, 2024
@spencergibb
Copy link
Member

Also resumeEndpointGloballyDisabled after disabling environmentWebEndpointExtensionEnabled

@hpoettker
Copy link
Contributor

I had a look after it failed when #1361 was merged. The problem is restartEndpointEnabled, which runs before environmentWebEndpointExtensionEnabled. When I run all tests of the class in my IDE a couple of times, I can reproduce it eventually.

The test triggers a context restart in a separate thread, and the test doesn't wait for that to finish. The subsequent test then gets ConcurrentModificationException as the logging bootstrappings get in the way of each other.

@spencergibb spencergibb removed this from 2024.0.0-M1 Sep 5, 2024
@ryanjbaxter ryanjbaxter removed this from 2024.0.0-M2 Oct 8, 2024
@spencergibb spencergibb removed this from the 4.2.0-M1 milestone Nov 15, 2024
@spencergibb spencergibb moved this to Todo in 2024.0.0 Nov 15, 2024
@spencergibb spencergibb removed this from 2024.0.0 Dec 2, 2024
@spencergibb spencergibb moved this to Todo in 2024.0.1 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

3 participants