Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell repo add/delete commands broken #632

Open
jvalkeal opened this issue May 18, 2018 · 4 comments
Open

Shell repo add/delete commands broken #632

jvalkeal opened this issue May 18, 2018 · 4 comments
Assignees
Labels
type/bug Is a bug report

Comments

@jvalkeal
Copy link
Contributor

Some issues with these commands

skipper:>repo delete --name xxxx
404 
Details of the error have been omitted. You can use the stacktrace command to print the full stacktrace.
skipper:>stacktrace 
org.springframework.web.client.HttpClientErrorException: 404 
	at org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:85)
	at org.springframework.cloud.skipper.client.SkipperClientResponseErrorHandler.handleError(SkipperClientResponseErrorHandler.java:78)
@jvalkeal jvalkeal added the type/technical-debt Techical Dept label May 18, 2018
jvalkeal added a commit to jvalkeal/spring-cloud-skipper that referenced this issue May 18, 2018
- This adds missing sections for repo add/delete, but only
  syntax snippets. Command samples for those should be added
  together with spring-cloud#632
- Fixes spring-cloud#626
@jvalkeal jvalkeal added the type/bug Is a bug report label May 18, 2018
@jvalkeal jvalkeal added this to the 1.0.5.RELEASE milestone May 18, 2018
@jvalkeal jvalkeal added ready and removed type/technical-debt Techical Dept labels May 18, 2018
@ilayaperumalg ilayaperumalg self-assigned this May 18, 2018
@ilayaperumalg
Copy link
Contributor

It looks like the REST repository for Skipper Repository doesn't expose the save and delete method invocations as per this.

I think we had a reason not to expose these endpoints as we wanted to avoid user deleting the default local repository etc., Perhaps, we can add some check and allow these methods to be exposed?

What do you think @jvalkeal @markpollack ?

@markpollack
Copy link
Contributor

As I recall, I purposely left this not exposed and thought that whoever started the skipper server would edit the yaml file. I suppose the right way is to add a role to that endpoint. Can we push this off to a backport targeting 1.0.6 so we can go ahead with the overdue scdf 1.5.1 release?

@markpollack
Copy link
Contributor

markpollack commented May 29, 2018

maybe remove the command or just log a more decent warning short term?

@sabbyanandan
Copy link
Contributor

We will revisit it in the context of RBAC in future.

@sabbyanandan sabbyanandan removed this from the 1.1.0.M1 milestone Jun 5, 2018
@sabbyanandan sabbyanandan added this to the 1.1.0.RC1 milestone Jul 17, 2018
@sabbyanandan sabbyanandan removed this from the 1.1.0.RC1 milestone Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Is a bug report
Projects
None yet
Development

No branches or pull requests

4 participants