-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell repo add/delete commands broken #632
Comments
- This adds missing sections for repo add/delete, but only syntax snippets. Command samples for those should be added together with spring-cloud#632 - Fixes spring-cloud#626
It looks like the REST repository for Skipper I think we had a reason not to expose these endpoints as we wanted to avoid user deleting the default What do you think @jvalkeal @markpollack ? |
As I recall, I purposely left this not exposed and thought that whoever started the skipper server would edit the yaml file. I suppose the right way is to add a role to that endpoint. Can we push this off to a backport targeting 1.0.6 so we can go ahead with the overdue scdf 1.5.1 release? |
maybe remove the command or just log a more decent warning short term? |
We will revisit it in the context of RBAC in future. |
Some issues with these commands
The text was updated successfully, but these errors were encountered: