-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Unicode character in project generation #1328
Comments
The |
Hello, if noone is working on this I could take it as a first timer contribution. |
The issue is yours @okan35. Thank you very much and let us know if you have any question. |
Hello, so basically I am trying to run the initializr-generator just so that at least I can the api for generation but I haven't been successful. What I have tried so far is doing So I just need to be able make it work basically, what would you suggest regarding this ? By the way I was able to start.spring.io even though I could not get the UI strangely. |
@okan35 thanks for the feedback. There are a number of tests in If you want to play around with curl against the service, you can give |
So basically I should not be providing a fix but just add an additional test in Also I used normalizer basically in I used it as below I believe that is kind of it since I could not really run the whole initializr web UI to generate a project.
|
@snicoll I have added a commit, with Idea that we should sanitize input, and convert accents character to normal char. |
Closing in favor of PR #1345 |
See spring-io/start.spring.io#990
I don't know how easy it would be to map the characters to something that would work but it's certainly worth researching. Or we could chose to fail upfront, rather than failing later as we do now.
The text was updated successfully, but these errors were encountered: