Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the defaults for the typical case #14

Open
wilkinsona opened this issue Mar 28, 2024 · 0 comments
Open

Simplify the defaults for the typical case #14

wilkinsona opened this issue Mar 28, 2024 · 0 comments

Comments

@wilkinsona
Copy link

It appears to be typical to use configuration like this:

url: ${{ env.OSSRH_URL }}
username: ${{ secrets.OSSRH_S01_TOKEN_USERNAME }}
password: ${{ secrets.OSSRH_S01_TOKEN_PASSWORD }}
staging-profile-name: ${{ secrets.OSSRH_STAGING_PROFILE_NAME }}
create: true
upload: true
generate-checksums: true
upload-parallel: 10
close: true
release: true

The above can be seen in @abilan's workflows. Spring Shell has very similar configuration as well.

#4 removed the need to configure the URL when using s01. Could similar updates to the other defaults be made as well? Specifically, I would welcome all of the following defaulting to true:

  • close
  • create
  • generate-checksums
  • release
  • upload

Combined with #4, this would reduce the configuration above to the following:

username: ${{ secrets.OSSRH_S01_TOKEN_USERNAME }}
password: ${{ secrets.OSSRH_S01_TOKEN_PASSWORD }}
staging-profile-name: ${{ secrets.OSSRH_STAGING_PROFILE_NAME }}
upload-parallel: 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant