Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate thanks for signing the CLA #144

Open
wilkinsona opened this issue Oct 28, 2016 · 3 comments
Open

Duplicate thanks for signing the CLA #144

wilkinsona opened this issue Oct 28, 2016 · 3 comments

Comments

@wilkinsona
Copy link
Contributor

wilkinsona commented Oct 28, 2016

spring-projects/spring-boot#7239

The users was thanked three times, and, barring a coincidence in timing, they appear to have been triggered by me interacting with the issue rather than the user signing the CLA.

I see two problems:

  1. Has the CLA actually been signed, or did my interaction trigger the thanks comment incorrectly?
  2. The comment was posted three times
@snicoll
Copy link

snicoll commented Oct 28, 2016

See also #140

@wilkinsona
Copy link
Contributor Author

wilkinsona commented Oct 28, 2016

Three payloads were delivered to the web hook for spring-projects/spring-boot#7239 at 2016-10-28 09:51:02. One unlabelled action and two labelled actions. I can't see why any of these alone should have triggered a comment that the CLA had been signed.

@mp911de
Copy link
Collaborator

mp911de commented Oct 28, 2016

Reading data from Github is eventually consistent... When an object was updated and that data is immediately read, then consistency issues may occur.

@rwinch we should reconsider "thanking for signing the CLA". In this case, the user signed the CLA without updating the PR (which is likely to happen if CLA was signed just jumping to cla.pivotal.io and not using the link in the PR). We had several scenarios where short-time persistence of "active" PR's would be beneficial. In this case, we would compensate for a slow Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants