Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CommitStatus getFullUrl #26

Open
rwinch opened this issue Feb 25, 2016 · 0 comments
Open

Add CommitStatus getFullUrl #26

rwinch opened this issue Feb 25, 2016 · 0 comments

Comments

@rwinch
Copy link
Collaborator

rwinch commented Feb 25, 2016

Right now the URL must be something like

https://123456.ngrok.io/sign/spring?repositoryId=spring-projects/spring-security&pullRequestId=1

However, we must also provide repositoryId and pullRequestId on the CommitStatus.

The CommitStatus should add a method of getFullUrl() which automatically adds the parameters to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rwinch