-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ActiveMQ module when ActiveMQ/Artemis and Testcontainers are selected #1415
Add ActiveMQ module when ActiveMQ/Artemis and Testcontainers are selected #1415
Conversation
start-site/src/main/java/io/spring/start/site/container/SimpleDockerServiceResolver.java
Outdated
Show resolved
Hide resolved
.../spring/start/site/extension/dependency/activemq/ActiveMQProjectGenerationConfiguration.java
Outdated
Show resolved
Hide resolved
Thanks! I've tested it, but there are some pieces missing: When i generate a 3.3.0-SNAPSHOT project, it doesn't include the private static final VersionRange SPRING_BOOT_3_3_0_OR_LATER = VersionParser.DEFAULT.parseRange("3.3.0"); doesn't match private static final VersionRange SPRING_BOOT_3_3_0_M2_OR_LATER = VersionParser.DEFAULT.parseRange("3.3.0-M2"); However, with that change, the generated test main looks like this: @Bean
@ServiceConnection
ActiveMQContainer<?> activemqContainer() {
return new ActiveMQContainer<>(DockerImageName.parse("apache/activemq-classic:latest"));
} When compiling, this fails with: > Task :compileTestJava FAILED
/home/mhalbritter/Downloads/demo330/src/test/java/com/example/demo330/TestDemo330Application.java:15: error: type ActiveMQContainer does not take parameters
ActiveMQContainer<?> activemqContainer() {
^
/home/mhalbritter/Downloads/demo330/src/test/java/com/example/demo330/TestDemo330Application.java:16: error: cannot infer type arguments for ActiveMQContainer
return new ActiveMQContainer<>(DockerImageName.parse("apache/activemq-classic:latest"));
^
reason: cannot use '<>' with non-generic class ActiveMQContainer
2 errors
FAILURE: Build failed with an exception. |
Thanks @mhalbritter ! I missed to set the |
Thanks! |
Testcontainers 1.19.4 offers an ActiveMQ module, which provides two implementations
ActiveMQContainer
andArtemisContainer
. Both, are already supported as part ofSpring Boot 3.3.0-M2.