Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelCachingConnectionProxy close #1186

Open
wang007 opened this issue Apr 28, 2020 · 1 comment
Open

ChannelCachingConnectionProxy close #1186

wang007 opened this issue Apr 28, 2020 · 1 comment
Milestone

Comments

@wang007
Copy link

wang007 commented Apr 28, 2020

why CachingConnectionFactory allocatedConnections field clear only in the resetConnection method ?
if ChannelCachingConnectionProxy is not open, clear this in allocatedConnections field on the destroy method

@garyrussell garyrussell added this to the Backlog milestone Apr 28, 2020
@garyrussell
Copy link
Contributor

Yes; I noticed that last week but decided it wasn't very important because the connection will be refreshed the next time it is used:

else if (!cachedConnection.isOpen()) {
try {
refreshProxyConnection(cachedConnection);
}
catch (Exception e) {
this.idleConnections.addLast(cachedConnection);
}
}

Feel free to submit a PR if you feel strongly about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants