Skip to content

Commit 79a816e

Browse files
committed
Adapt to changes in HttpMessageConverter customization API in latest Framework.
1 parent cfdd126 commit 79a816e

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

src/main/java/org/springframework/data/web/config/SpringDataWebConfiguration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
import org.springframework.format.FormatterRegistry;
4242
import org.springframework.format.support.FormattingConversionService;
4343
import org.springframework.http.converter.HttpMessageConverter;
44-
import org.springframework.http.converter.HttpMessageConverters;
44+
import org.springframework.http.converter.HttpMessageConverters.ServerBuilder;
4545
import org.springframework.util.Assert;
4646
import org.springframework.util.ClassUtils;
4747
import org.springframework.web.method.support.HandlerMethodArgumentResolver;
@@ -153,13 +153,13 @@ public void addArgumentResolvers(List<HandlerMethodArgumentResolver> argumentRes
153153
}
154154

155155
@Override
156-
public void configureMessageConverters(HttpMessageConverters.Builder builder) {
156+
public void configureMessageConverters(ServerBuilder builder) {
157157

158158
List<HttpMessageConverter<?>> converters = new ArrayList<>();
159159
configureMessageConverters(converters);
160160

161161
for (HttpMessageConverter<?> converter : converters) {
162-
builder.additionalMessageConverter(converter);
162+
builder.customMessageConverter(converter);
163163
}
164164
}
165165

src/test/java/org/springframework/data/web/config/EnableSpringDataWebSupportIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ PageSampleController controller() {
134134
}
135135

136136
@Override
137-
protected void configureMessageConverters(HttpMessageConverters.Builder builder) {
137+
protected void configureMessageConverters(HttpMessageConverters.ServerBuilder builder) {
138138
builder.jsonMessageConverter(new JacksonJsonHttpMessageConverter(
139139
JsonMapper.builder().addModules(modules.toArray(new JacksonModule[0])).build()));
140140
}

src/test/java/org/springframework/data/web/config/SpringDataWebConfigurationIntegrationTests.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -55,60 +55,60 @@ class SpringDataWebConfigurationIntegrationTests {
5555
@Test // DATACMNS-987
5656
void shouldNotLoadJacksonConverterWhenJacksonNotPresent() {
5757

58-
HttpMessageConverters.Builder builder = mock(HttpMessageConverters.Builder.class);
58+
HttpMessageConverters.ServerBuilder builder = mock(HttpMessageConverters.ServerBuilder.class);
5959

6060
createConfigWithClassLoader(
6161
HidingClassLoader.hide(ObjectMapper.class, com.fasterxml.jackson.databind.ObjectMapper.class),
6262
it -> it.configureMessageConverters(builder));
6363

64-
verify(builder).additionalMessageConverter(any(XmlBeamHttpMessageConverter.class));
64+
verify(builder).customMessageConverter(any(XmlBeamHttpMessageConverter.class));
6565
verifyNoMoreInteractions(builder);
6666
}
6767

6868
@Test // DATACMNS-987
6969
void shouldNotLoadJacksonConverterWhenJaywayNotPresent() {
7070

71-
HttpMessageConverters.Builder builder = mock(HttpMessageConverters.Builder.class);
71+
HttpMessageConverters.ServerBuilder builder = mock(HttpMessageConverters.ServerBuilder.class);
7272

7373
createConfigWithClassLoader(HidingClassLoader.hide(DocumentContext.class),
7474
it -> it.configureMessageConverters(builder));
7575

76-
verify(builder).additionalMessageConverter(any(XmlBeamHttpMessageConverter.class));
76+
verify(builder).customMessageConverter(any(XmlBeamHttpMessageConverter.class));
7777
verifyNoMoreInteractions(builder);
7878
}
7979

8080
@Test // DATACMNS-987
8181
void shouldNotLoadXBeamConverterWhenXBeamNotPresent() throws Exception {
8282

83-
HttpMessageConverters.Builder builder = mock(HttpMessageConverters.Builder.class);
83+
HttpMessageConverters.ServerBuilder builder = mock(HttpMessageConverters.ServerBuilder.class);
8484

8585
ClassLoader classLoader = HidingClassLoader.hide(XBProjector.class);
8686
createConfigWithClassLoader(classLoader, it -> it.configureMessageConverters(builder));
8787

88-
verify(builder, never()).additionalMessageConverter(any(XmlBeamHttpMessageConverter.class));
88+
verify(builder, never()).customMessageConverter(any(XmlBeamHttpMessageConverter.class));
8989
}
9090

9191
@Test // DATACMNS-987
9292
void shouldLoadAllConvertersWhenDependenciesArePresent() throws Exception {
9393

94-
HttpMessageConverters.Builder builder = mock(HttpMessageConverters.Builder.class);
94+
HttpMessageConverters.ServerBuilder builder = mock(HttpMessageConverters.ServerBuilder.class);
9595

9696
createConfigWithClassLoader(getClass().getClassLoader(), it -> it.configureMessageConverters(builder));
9797

98-
verify(builder).additionalMessageConverter(any(XmlBeamHttpMessageConverter.class));
99-
verify(builder).additionalMessageConverter(any(ProjectingJacksonHttpMessageConverter.class));
98+
verify(builder).customMessageConverter(any(XmlBeamHttpMessageConverter.class));
99+
verify(builder).customMessageConverter(any(ProjectingJacksonHttpMessageConverter.class));
100100
}
101101

102102
@Test // DATACMNS-1152
103103
void usesCustomObjectMapper() {
104104

105105
createConfigWithClassLoader(getClass().getClassLoader(), it -> {
106106

107-
HttpMessageConverters.Builder builder = mock(HttpMessageConverters.Builder.class);
107+
HttpMessageConverters.ServerBuilder builder = mock(HttpMessageConverters.ServerBuilder.class);
108108
ArgumentCaptor<HttpMessageConverter> captor = ArgumentCaptor.forClass(HttpMessageConverter.class);
109109

110110
it.configureMessageConverters(builder);
111-
verify(builder, atLeast(1)).additionalMessageConverter(captor.capture());
111+
verify(builder, atLeast(1)).customMessageConverter(captor.capture());
112112

113113
// Converters contains ProjectingJackson2HttpMessageConverter with custom ObjectMapper
114114

0 commit comments

Comments
 (0)