Polishing.

Reformat code. Simplify flow. Add ticket reference to test.

See #3287
Original pull request: #3219

Author: mp911de

src/main/java/org/springframework/data/repository/config/RepositoryConfigurationDelegate.java

@@ -15,13 +15,28 @@
  */
 package org.springframework.data.repository.config;
 
+import java.lang.reflect.TypeVariable;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
+
 import org.springframework.beans.factory.config.BeanDefinition;
 import org.springframework.beans.factory.config.ConfigurableBeanFactory;
 import org.springframework.beans.factory.config.DependencyDescriptor;
 import org.springframework.beans.factory.parsing.BeanComponentDefinition;
-import org.springframework.beans.factory.support.*;
+import org.springframework.beans.factory.support.AutowireCandidateResolver;
+import org.springframework.beans.factory.support.BeanDefinitionBuilder;
+import org.springframework.beans.factory.support.BeanDefinitionReaderUtils;
+import org.springframework.beans.factory.support.BeanDefinitionRegistry;
+import org.springframework.beans.factory.support.DefaultListableBeanFactory;
+import org.springframework.beans.factory.support.RootBeanDefinition;
 import org.springframework.context.annotation.ContextAnnotationAutowireCandidateResolver;
 import org.springframework.context.support.GenericApplicationContext;
 import org.springframework.core.ResolvableType;
@@ -43,10 +58,6 @@
 import org.springframework.util.ClassUtils;
 import org.springframework.util.StopWatch;
 
-import java.lang.reflect.TypeVariable;
-import java.util.*;
-import java.util.stream.Collectors;
-
 /**
  * Delegate for configuration integration to reuse the general way of detecting repositories. Customization is done by
  * providing a configuration format specific {@link RepositoryConfigurationSource} (currently either XML or annotations
@@ -65,6 +76,9 @@ public class RepositoryConfigurationDelegate {
 	private static final String MULTIPLE_MODULES = "Multiple Spring Data modules found, entering strict repository configuration mode";
 	private static final String NON_DEFAULT_AUTOWIRE_CANDIDATE_RESOLVER = "Non-default AutowireCandidateResolver (%s) detected. Skipping the registration of LazyRepositoryInjectionPointResolver. Lazy repository injection will not be working";
 
+	private static final List<Class<?>> DEFAULT_AUTOWIRE_CANDIDATE_RESOLVERS = List
+			.of(ContextAnnotationAutowireCandidateResolver.class, LazyRepositoryInjectionPointResolver.class);
+
 	private static final Log logger = LogFactory.getLog(RepositoryConfigurationDelegate.class);
 
 	private final RepositoryConfigurationSource configurationSource;
@@ -82,7 +96,7 @@ public class RepositoryConfigurationDelegate {
 	 * @param environment must not be {@literal null}.
 	 */
 	public RepositoryConfigurationDelegate(RepositoryConfigurationSource configurationSource,
-										   ResourceLoader resourceLoader, Environment environment) {
+			ResourceLoader resourceLoader, Environment environment) {
 
 		this.isXml = configurationSource instanceof XmlRepositoryConfigurationSource;
 		boolean isAnnotation = configurationSource instanceof AnnotationRepositoryConfigurationSource;
@@ -107,7 +121,7 @@ public RepositoryConfigurationDelegate(RepositoryConfigurationSource configurati
 	 *         {@link Environment}.
 	 */
 	private static Environment defaultEnvironment(@Nullable Environment environment,
-												  @Nullable ResourceLoader resourceLoader) {
+			@Nullable ResourceLoader resourceLoader) {
 
 		if (environment != null) {
 			return environment;
@@ -127,7 +141,7 @@ private static Environment defaultEnvironment(@Nullable Environment environment,
 	 * @see org.springframework.beans.factory.support.BeanDefinitionRegistry
 	 */
 	public List<BeanComponentDefinition> registerRepositoriesIn(BeanDefinitionRegistry registry,
-																RepositoryConfigurationExtension extension) {
+			RepositoryConfigurationExtension extension) {
 
 		if (logger.isInfoEnabled()) {
 			logger.info(LogMessage.format("Bootstrapping Spring Data %s repositories in %s mode.", //
@@ -213,7 +227,7 @@ public List<BeanComponentDefinition> registerRepositoriesIn(BeanDefinitionRegist
 	}
 
 	private void registerAotComponents(BeanDefinitionRegistry registry, RepositoryConfigurationExtension extension,
-									   Map<String, RepositoryConfigurationAdapter<?>> metadataByRepositoryBeanName) {
+			Map<String, RepositoryConfigurationAdapter<?>> metadataByRepositoryBeanName) {
 
 		BeanDefinitionBuilder repositoryAotProcessor = BeanDefinitionBuilder
 				.rootBeanDefinition(extension.getRepositoryAotProcessor()).setRole(BeanDefinition.ROLE_INFRASTRUCTURE);
@@ -236,37 +250,32 @@ private void registerAotComponents(BeanDefinitionRegistry registry, RepositoryCo
 	 * @param registry must not be {@literal null}.
 	 */
 	private static void potentiallyLazifyRepositories(Map<String, RepositoryConfiguration<?>> configurations,
-													  BeanDefinitionRegistry registry, BootstrapMode mode) {
+			BeanDefinitionRegistry registry, BootstrapMode mode) {
 
-		if (!DefaultListableBeanFactory.class.isInstance(registry) || BootstrapMode.DEFAULT.equals(mode)) {
+		if (!(registry instanceof DefaultListableBeanFactory beanFactory) || BootstrapMode.DEFAULT.equals(mode)) {
 			return;
 		}
 
-		DefaultListableBeanFactory beanFactory = DefaultListableBeanFactory.class.cast(registry);
 		AutowireCandidateResolver resolver = beanFactory.getAutowireCandidateResolver();
 
-		if (!Arrays.asList(ContextAnnotationAutowireCandidateResolver.class, LazyRepositoryInjectionPointResolver.class)
-				.contains(resolver.getClass())) {
+		if (!DEFAULT_AUTOWIRE_CANDIDATE_RESOLVERS.contains(resolver.getClass())) {
 
 			logger.warn(LogMessage.format(NON_DEFAULT_AUTOWIRE_CANDIDATE_RESOLVER, resolver.getClass().getName()));
-
 			return;
 		}
 
-		AutowireCandidateResolver newResolver = LazyRepositoryInjectionPointResolver.class.isInstance(resolver) //
-				? LazyRepositoryInjectionPointResolver.class.cast(resolver).withAdditionalConfigurations(configurations) //
+		AutowireCandidateResolver newResolver = resolver instanceof LazyRepositoryInjectionPointResolver lazy //
+				? lazy.withAdditionalConfigurations(configurations) //
 				: new LazyRepositoryInjectionPointResolver(configurations);
 
 		beanFactory.setAutowireCandidateResolver(newResolver);
 
-		if (mode.equals(BootstrapMode.DEFERRED)) {
+		if (mode.equals(BootstrapMode.DEFERRED)
+				&& !beanFactory.containsBean(DeferredRepositoryInitializationListener.class.getName())) {
 
 			logger.debug("Registering deferred repository initialization listener.");
-
-			if (!beanFactory.containsBean(DeferredRepositoryInitializationListener.class.getName())) {
-				beanFactory.registerSingleton(DeferredRepositoryInitializationListener.class.getName(),
-						new DeferredRepositoryInitializationListener(beanFactory));
-			}
+			beanFactory.registerSingleton(DeferredRepositoryInitializationListener.class.getName(),
+					new DeferredRepositoryInitializationListener(beanFactory));
 		}
 	}
 
@@ -276,7 +285,7 @@ private static void potentiallyLazifyRepositories(Map<String, RepositoryConfigur
 	 * scanning.
 	 *
 	 * @return {@literal true} if multiple data store repository implementations are present in the application. This
-	 *         typically means an Spring application is using more than 1 type of data store.
+	 *         typically means a Spring application is using more than 1 type of data store.
 	 */
 	private boolean multipleStoresDetected() {
 

src/test/java/org/springframework/data/repository/config/RepositoryConfigurationDelegateUnitTests.java

@@ -15,12 +15,20 @@
  */
 package org.springframework.data.repository.config;
 
+import static org.assertj.core.api.Assertions.*;
+
+import java.lang.reflect.TypeVariable;
+import java.util.List;
+import java.util.Optional;
+import java.util.UUID;
+
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mockito;
 import org.mockito.junit.jupiter.MockitoExtension;
 import org.mockito.junit.jupiter.MockitoSettings;
 import org.mockito.quality.Strictness;
+
 import org.springframework.aop.framework.Advised;
 import org.springframework.aot.hint.RuntimeHints;
 import org.springframework.beans.factory.ListableBeanFactory;
@@ -52,13 +60,6 @@
 import org.springframework.data.repository.sample.AddressRepositoryClient;
 import org.springframework.data.repository.sample.ProductRepository;
 
-import java.lang.reflect.TypeVariable;
-import java.util.List;
-import java.util.Optional;
-import java.util.UUID;
-
-import static org.assertj.core.api.Assertions.assertThat;
-
 /**
  * Unit tests for {@link RepositoryConfigurationDelegate}.
  *
@@ -112,8 +113,8 @@ void registersDeferredRepositoryInitializationListener() {
 		assertThat(beanFactory.getBeanNamesForType(DeferredRepositoryInitializationListener.class)).isNotEmpty();
 	}
 
-	@Test
-	void registersMultiDeferredRepositoryInitializationListener() {
+	@Test // GH-3287
+	void registersOneDeferredRepositoryInitializationListener() {
 
 		var beanFactory = assertLazyRepositoryBeanSetup(DeferredConfig.class, OtherDeferredConfig.class);