Optimized `QueryUtils.applyAndBind(…)` using `IN(entities)`does not work with EclipseLink

[joeltran]

Dear Spring Data JPA,

While upgrading from Spring 3.4.x to spring 3.5.x, I notice a regression issue while calling issueRepository.deleteAllInBatch() of a JpaRepository object. We are now facing the following error:

Caused by: java.lang.IllegalArgumentException: You have attempted to set a value of type class java.util.Vector for parameter 1 with expected type of class com.issue.IssueTable from query string delete from IssueTable x where x IN (?1).

While investigating the root cause, I notice the following commit which could have introduce the side effect.

96968e9

I tried to use the issueRepository.deleteAllByIdInBatch() method which also does not work and throws the following error:

I guess there is a missing "x." before the id in the generated SQL.

I have attached 3 java files (1 entity, 1 repository, 1 unit test) + pom in order to reproduce the issue.

Best regards,
Joel

SpringJPAIssueTest.java
IssueTable.java
IssueRepository.java
pom.xml.txt

[mp911de]

The difference between both statements is:

Before #2870

DELETE FROM User u where u = ?1 or u = ?2 or u = ?3

After #2870

DELETE FROM User u where u IN (?1)

We're not targeting the identifier specifically but passing on the entire entity. It turns out that EclipseLink isn't able to leverage IN using entities. Generally speaking, Eclipselink has troubles with several IN queries not being able to unwrap a collection of items.

[joeltran]

Hi Mark,

Thanks for addressing the deleteAllInBatch() issue. I forgot to put the trace for the second issue with the deleteAllByIdInBatch() in the above example which is causing the following dump:

Caused by: Exception [EclipseLink-0] (Eclipse Persistence Services - 4.0.7.v202506240759-923a428d4722d199eff24e730890e156ce7ea9de): org.eclipse.persistence.exceptions.JPQLException
Exception Description: Problem compiling [delete from IssueTable x where id in :ids]. 
[31, 33] The identification variable 'id' is not defined in the FROM clause.
	at org.eclipse.persistence.internal.jpa.jpql.HermesParser.buildException(HermesParser.java:159)
	at org.eclipse.persistence.internal.jpa.jpql.HermesParser.validate(HermesParser.java:337)

The query is created by the following SimpleJpaRepository<T,ID>.deleteAllByIdInBatch(Iterable) line: 251

The method deleteAllByIdInBatch() is calling "Query query = entityManager.createQuery(queryString);" with a wrong SQL.

Wrong: "delete from IssueTable x where id in :ids"
Valid: "delete from IssueTable x where x.id in :ids

Kindly reuse the example initially sent (java files + pom) to reproduce the issue using the test method testDeleteAllByIdInBatch().

Best regards,
Joel