Skip to content

Integer overflow in bean ordering causes inadvertent prioritization #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bgiddens opened this issue May 9, 2025 · 0 comments
Closed

Integer overflow in bean ordering causes inadvertent prioritization #2477

bgiddens opened this issue May 9, 2025 · 0 comments
Assignees
@mp911de
Labels
type: bug A general bug
Milestone
4.3.12 (2024.0.12)

Comments

@bgiddens
Copy link

bgiddens commented May 9, 2025

Error is here

The RepositoryRelProvider uses the order with Ordered.LOWEST_PRECEDENCE + 10, indicating lower then the intended lowest precedence. Since the lowest precedence is Integer.MAX_VALUE, this rolls back to a value near Integer.MIN_VALUE, causing this class to have extremely high precedence.

In all likelihood the intended behavior was low but not minimal ordering, i.e. Ordered.LOWEST_PRECEDENCE - 10.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 9, 2025
therepanic added a commit to therepanic/spring-data-rest that referenced this issue May 9, 2025
@therepanic
fix integer overflow in @Order of RepositoryRelProvider (spring-p…
af4dccd 
…rojects#2477)

Signed-off-by: Andrey Litvitski <[email protected]>
@therepanic therepanic mentioned this issue May 9, 2025
Closed
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 12, 2025
@mp911de mp911de self-assigned this May 12, 2025
@mp911de mp911de changed the title [Bug] Integer overflow in bean ordering causes inadvertent prioritization Integer overflow in bean ordering causes inadvertent prioritization May 12, 2025
mp911de added a commit that referenced this issue May 13, 2025
@mp911de
Polishing.
b1d0cb8 
Add test.

See: #2477
Original pull request: #2478
mp911de pushed a commit that referenced this issue May 13, 2025
@therepanic @mp911de
Fix integer overflow in @Order of RepositoryRelProvider.
bf7e8e5 
Signed-off-by: Andrey Litvitski <[email protected]>

Closes: #2477
Original pull request: #2478
mp911de added a commit that referenced this issue May 13, 2025
@mp911de
Polishing.
ed8dc82 
Add test.

See: #2477
Original pull request: #2478
mp911de pushed a commit that referenced this issue May 13, 2025
@therepanic @mp911de
Fix integer overflow in @Order of RepositoryRelProvider.
e103f68 
Signed-off-by: Andrey Litvitski <[email protected]>

Closes: #2477
Original pull request: #2478
mp911de added a commit that referenced this issue May 13, 2025
@mp911de
Polishing.
26e5648 
Add test.

See: #2477
Original pull request: #2478
@mp911de mp911de added this to the 4.3.12 (2024.0.12) milestone May 13, 2025
mp911de pushed a commit that referenced this issue May 13, 2025
@therepanic @mp911de
Fix integer overflow in @Order of RepositoryRelProvider.
10f9b78 
Signed-off-by: Andrey Litvitski <[email protected]>

Closes: #2477
Original pull request: #2478
mp911de added a commit that referenced this issue May 13, 2025
@mp911de
Polishing.
36bac85 
Add test.

See: #2477
Original pull request: #2478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: bug A general bug
Projects
None yet
Milestone
4.3.12 (2024.0.12)
Development

Successfully merging a pull request may close this issue.

Fix integer overflow in @Order of RepositoryRelProvider therepanic/spring-data-rest
3 participants
@mp911de @spring-projects-issues @bgiddens