Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update docs to show controlBusOnRegistry(), not controlBus() #9683

Open
joshlong opened this issue Nov 24, 2024 · 1 comment
Open

Please update docs to show controlBusOnRegistry(), not controlBus() #9683

joshlong opened this issue Nov 24, 2024 · 1 comment
Labels
in: core type: refactoring
Milestone
6.5.0-M1

Comments

@joshlong
Copy link
Member

https://docs.spring.io/spring-integration/reference/control-bus.html <- the docs here show the now deprecated controlBus() methods on the IntegrationFlow DSL. Please update to show controlBusOnRegistry()
@joshlong joshlong added status: waiting-for-triage The issue need to be evaluated and its future decided type: bug labels Nov 24, 2024
@artembilan
Copy link
Member

artembilan commented Nov 27, 2024 •
edited
Loading

Well, the idea is to deprecate a new controlBusOnRegistry() in the next version and de-deprecate the old one, restoring, essentially, the status-quo of the mentioned doc.

@artembilan artembilan added this to the 6.5.0-M1 milestone Dec 2, 2024
@artembilan artembilan added in: core type: refactoring and removed status: waiting-for-triage The issue need to be evaluated and its future decided type: bug labels Dec 2, 2024
artembilan added a commit that referenced this issue Dec 2, 2024
@artembilan
Adjust BaseIntegrationFlowDefinition.controlBus() deprecation
6c42630 
Related to: #9683.

Since we are going to restore `controlBus()` for convenience,
and only one way of Control Bus pattern, based on the `ControlBusCommandRegistry`, there is no need to have another `controlBusOnRegistry()` method

* Also fix link for `error-handling` chapter from the `special-channels.adoc`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core type: refactoring
Projects
None yet
Milestone
6.5.0-M1
Development

No branches or pull requests
2 participants
@joshlong @artembilan