A code style question

[wzq1022]

In KafkaListenerEndpointRegistry , line 399

   	if (listenerContainersToStop.size() > 0) {
   		...
   	}

why not use

		if (!listenerContainersToStop.isEmpty()) {
			...
		}

Normally, IDEA will prompt for modification, but why didn't the person who modified this file modify it? Is there any difference? I'm curious.

[artembilan]

I think such a suggestion from the IDEA has been introduced after that change had been made in this class - five years ago: #1135.

So, there is no limit for perfection and that indeed has to be fixed as it is suggested: https://stackoverflow.com/questions/9341740/ifliststr-size-0-versus-ifliststr-isempty.

Converting this to issue and feel free to contribute the fix: https://github.com/spring-projects/spring-kafka/blob/main/CONTRIBUTING.adoc

[artembilan]

Here it is: #3349

[wzq1022]

thanks for your reply.