Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Cloud Stream Pulsar Binder Base Implementation #138

Closed
onobc opened this issue Sep 21, 2022 · 3 comments
Closed

Spring Cloud Stream Pulsar Binder Base Implementation #138

onobc opened this issue Sep 21, 2022 · 3 comments
Assignees
Milestone

Comments

@onobc
Copy link
Collaborator

onobc commented Sep 21, 2022

No description provided.

@onobc onobc modified the milestone: 0.1.0-M1 Sep 23, 2022
@onobc onobc removed the theme: ga label Oct 24, 2022
@onobc
Copy link
Collaborator Author

onobc commented Dec 8, 2022

We will leverage the SI channel adapters from #137

@sobychacko sobychacko self-assigned this Dec 15, 2022
@sobychacko sobychacko added this to the 1.0.0 milestone Dec 15, 2022
@onobc
Copy link
Collaborator Author

onobc commented Jan 30, 2023

@sobychacko is this more of an "epic" for the binder in general? If so, we should probably link the commits that have went into this as I don't see any links from here. Also, let's add a bullet list of items left to call this one done for 1.0.0.

Another option would be to edit this title to "SCS Pulsar Binder base implementation" and close it w/ the several commits you have added towards this. Then we can open an issue for the remaining work (docs, etc..).

Whatever you decide is fine - just trying to understand what we have left to do on the "SCSt Pulsar Binder".

I think the latter option is a bit more flexible as one of those tasks is "Replace SB impl w/ SI adapters once available". Even if we get to the SI adapters, I doubt we will have to also replace the SB impl. Or it would be a stretch goal at best.

@sobychacko
Copy link
Collaborator

sobychacko commented Jan 30, 2023

@onobc Good idea to close this issue with the commits already went in. We will create more issues for further changes.

Following are the binder related commits:

3387da1

1969c8a

4a10825

ada87db

ea1597a

bd75eef

f4d1081

9478c49

@sobychacko sobychacko changed the title Spring Cloud Stream Pulsar Binder Spring Cloud Stream Pulsar Binder Base Implementation Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants