-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider reverting change to revision attribute in pom #480
Comments
Hey, Stephane! Thank you for feedback! So, my logic was like this: I'm not familiar with Maven flatten plugin, but introducing it just for And if you talk about alignment and deviations, there is the reusable workflows project which we use successfully in many places. We may discuss this further offline. |
Yeah, I am not denying that. I missed to add the last step in https://maven.apache.org/maven-ci-friendly.html, sorry about that.
I disagree with the analysis. The revision property has been introduced to mimic many other projects that use it. The link that I've shared above explains the benefit of using such property. The property hasn't been only introduced as a way to to get the version when releasing.
Sure, it's another reusable workflow you could use rather than this one, I don't have an opinion about that. But that's two different topic. Right now, it's neither. |
Thank you for the link, Stephane! So, I'll revert to
|
Fixes: spring-projects#480 * Add `flatten-maven-plugin` to resolve properties and remove unnecessary build info from the final POM of the artifact to install/deploy
Please consider reverting #474 and everything that it caused. The purpose of the GitHub workflow is to make sure that things as much aligned as possible and each deviation from that makes Spring Retry special for no good reason.
The maven flatten plugin can easily be introduced to publish a POM that's more clean and without unnecessary information. That would be a plus as well.
The text was updated successfully, but these errors were encountered: