Skip to content

Add JdbcRelyingPartyRegistrationRepository #16012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sasirekha98 opened this issue Oct 30, 2024 · 4 comments · May be fixed by #17077
Open

Add JdbcRelyingPartyRegistrationRepository #16012

sasirekha98 opened this issue Oct 30, 2024 · 4 comments · May be fixed by #17077
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement

Comments

@sasirekha98
Copy link

sasirekha98 commented Oct 30, 2024

I have an application where the SP metadata is generated as XML and put in the database. We pull the XML and generate the authentication request. When I want to move to Spring Security, I don't find the same option where I can get the relying party details from the data source or directly provide the XML file location.

Currently, as per my understanding, we have the option to load the XML file of the IDP through metadata locations through spring security like this

RelyingPartyRegistrations
.fromMetadataLocation(oktaMetadataUrl)
.registrationId("okta")).build();

Similar to that, it would be nice to have an option where we can load the relying party details when we have them in the database or some location already. We just need to load that file instead of adding the details one by one to the RelyingpartyRegistration.

it will be easier if I have an option where I have to mention the metadata location of the sp as well like this
RelyingPartyRegistrations
.fromMetadataLocationofSP(location)
.fromMetadataLocationofIDP(oktaMetadataUrl)
.registrationId("okta")).build();

@sasirekha98 sasirekha98 added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Oct 30, 2024
@sasirekha98 sasirekha98 changed the title There is no option to create relyingparty details similar to the RelyingPartyRegistrations for assertingparty in saml2 There is no option to create relyingparty details through datasource in saml2 Oct 30, 2024
@jzheaux jzheaux changed the title There is no option to create relyingparty details through datasource in saml2 Add JdbcRelyingPartyRegistrationRepository Nov 8, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Nov 8, 2024

Thanks for the suggestion, @sasirekha98. Are you interested in supplying a PR for this? You can look at the various JdbcXXX classes already in Spring Security for guidance.

@jzheaux jzheaux added status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 8, 2024
@wapkch
Copy link

wapkch commented Nov 14, 2024

@jzheaux May i work on this?

@jzheaux
Copy link
Contributor

jzheaux commented Mar 20, 2025

Sorry that I missed you, @wapkch. Are you still interested in working on this? If so, please comment here and feel free also to proceed with a PR.

@wapkch
Copy link

wapkch commented Mar 24, 2025

@jzheaux Yes, I would be happy to work on this. I’ll proceed with the PR shortly.

@jzheaux jzheaux added in: saml2 An issue in SAML2 modules and removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Apr 1, 2025
wapkch added a commit to wapkch/spring-security that referenced this issue Apr 29, 2025
wapkch pushed a commit to wapkch/spring-security that referenced this issue May 8, 2025
wapkch added a commit to wapkch/spring-security that referenced this issue May 8, 2025
wapkch pushed a commit to wapkch/spring-security that referenced this issue May 8, 2025
wapkch pushed a commit to wapkch/spring-security that referenced this issue May 8, 2025
wapkch pushed a commit to wapkch/spring-security that referenced this issue May 8, 2025
wapkch pushed a commit to wapkch/spring-security that referenced this issue May 8, 2025
@wapkch wapkch linked a pull request May 8, 2025 that will close this issue
wapkch pushed a commit to wapkch/spring-security that referenced this issue May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
4 participants
@jzheaux @wapkch @sasirekha98 and others