Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viem support? #173

Open
mlenser opened this issue Jul 13, 2023 · 13 comments
Open

Viem support? #173

mlenser opened this issue Jul 13, 2023 · 13 comments

Comments

@mlenser
Copy link

mlenser commented Jul 13, 2023

Is there any plan to support Viem? It's made by the wagmi team as an alternative to ethers.

@conwayconstar
Copy link

conwayconstar commented Jul 31, 2023

I created a viem version here https://github.com/feelsgoodman-web3/siwveim

@w4ll3
Copy link
Member

w4ll3 commented Aug 1, 2023

Hello, we are discussing how to address this, since the library went through an audit it gets a little more complicated to replace such a vital library. Hope you understand!

@reslear
Copy link

reslear commented Dec 25, 2023

in the end, we should 👍
maybe @conwayconstar create a PR?

@nfts2me
Copy link

nfts2me commented Jan 9, 2024

It would be awesome to have viem support or directly replace ethers.

@FrancoAguzzi
Copy link

+1 vote to have viem support 🙏🏼

@reslear
Copy link

reslear commented Apr 18, 2024

So i write small lib, also welcome to testing simplified siwe with Viem 2

https://github.com/reslear/simple-siwe

Comparison

Package Install size Linting Engine Parser
simple-siwe v0.1.4 install size average Viem v2 own (beta)
eip-login v0.1.0 install size average Viem v2 -
siwviem v1.3.0 install size high Viem v1 @spruceid/siwe-parser
siwe v2.3.2 install size high ethersjs @spruceid/siwe-parser
siwe-viem v0.1.0 install size high Viem v2 @spruceid/siwe-parser

@2facedsquid
Copy link

any update on this?

@sbihel
Copy link
Member

sbihel commented Apr 23, 2024

We are not planning to add support for viem but would welcome a contribution. As this library already supports both ethers.js v5 and v6 I believe the "crypto backend" is abstracted enough to make such addition relatively easily, unless I'm missing something.

@conwayconstar
Copy link

Say no more!

@nfts2me
Copy link

nfts2me commented Apr 23, 2024

We are not planning to add support for viem but would welcome a contribution. As this library already supports both ethers.js v5 and v6 I believe the "crypto backend" is abstracted enough to make such addition relatively easily, unless I'm missing something.

I'd say that you are missing what we believe is very important.
Quite a lot of websites use Viem/Wagmi.
And quite a lot, like us, the only usage of ethers is from this package, leading to an unnecesary increase of package downloading from the users which leads to a worse user experience, specially on smartphones / contries with slow Internet connections.

@reslear
Copy link

reslear commented Apr 23, 2024

@nfts2me Yes and no, there's also a deps problem (like parsers based on apg-js), See my Comparison above packages on viem ~2mb.

however siwe 2.8mb + parser 2.66 + ethers 18.8MB = ~23mb

hence the motivation to make https://github.com/reslear/simple-siwe a scaled-down copy without dependencies

@reslear
Copy link

reslear commented May 20, 2024

Good news wevm/viem#2280

@reslear
Copy link

reslear commented Jun 6, 2024

we can close the subject @sbihel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants