use ssi 0.9 #4
Closed
use ssi 0.9 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
timothee-haudebourg
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Blocking this PR until w3c/vc-bitstring-status-list#176 has been fixed and the vc-barcodes spec has been updated.
| @@ -99,9 +100,18 @@ impl TerseBitstringStatusListEntry { | |||
| ) | |||
| .unwrap(); | |||
|
|
|||
| // TODO: determine status size based on info.list_len ? | |||
| let status_size = StatusSize::default(); | |||
There was a problem hiding this comment.
That's not covered by the vc-barcodes specification, so we can't upgrade ssi yet. See w3c-ccg/vc-barcodes#19 vc-barcodes repository, and the referenced issue on the vc-bitstring-status-list repository.
Ryanmtate
force-pushed
the
use-ssi-0.9
branch
from
3f0ff73 to
c1c99da
Compare
|
@Ryanmtate I since added back support for the specific version of bitstring status list needed by vc-barcodes. It's in this module. If you use it, you shouldn't have to change any function's code. |
|
Closing in favor of #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.