From f53d0d27107ca4823628479f8182673935268f99 Mon Sep 17 00:00:00 2001
From: vol4onok <alexander.veselov@spryker.com>
Date: Tue, 23 Jul 2024 14:52:04 +0300
Subject: [PATCH 1/2] ACP-3468: Added additional payment data to payment entity

---
 .../Shared/AppPayment/Transfer/app_payment.transfer.xml        | 2 +-
 .../Persistence/Propel/Payment/Mapper/PaymentMapper.php        | 3 ---
 tests/_data/app_payment.databuilder.xml                        | 2 +-
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/Spryker/Shared/AppPayment/Transfer/app_payment.transfer.xml b/src/Spryker/Shared/AppPayment/Transfer/app_payment.transfer.xml
index 035e4b2..f78fb9f 100644
--- a/src/Spryker/Shared/AppPayment/Transfer/app_payment.transfer.xml
+++ b/src/Spryker/Shared/AppPayment/Transfer/app_payment.transfer.xml
@@ -122,7 +122,7 @@
         <property name="redirectSuccessUrl" type="string"/>
         <property name="redirectCancelUrl" type="string"/>
         <property name="additionalPaymentData" type="array" associative="true" singular="additionalPaymentDatum"/>
-        <property name="details" type="array" associative="true" singular="detail"/>
+        <property name="details" type="string"/>
     </transfer>
 
     <transfer name="PaymentRefund" strict="true">
diff --git a/src/Spryker/Zed/AppPayment/Persistence/Propel/Payment/Mapper/PaymentMapper.php b/src/Spryker/Zed/AppPayment/Persistence/Propel/Payment/Mapper/PaymentMapper.php
index 79b1b3a..37fbb2c 100644
--- a/src/Spryker/Zed/AppPayment/Persistence/Propel/Payment/Mapper/PaymentMapper.php
+++ b/src/Spryker/Zed/AppPayment/Persistence/Propel/Payment/Mapper/PaymentMapper.php
@@ -21,11 +21,9 @@ public function mapPaymentTransferToPaymentEntity(PaymentTransfer $paymentTransf
     {
         $quoteTransfer = $paymentTransfer->getQuoteOrFail();
         $quoteJson = json_encode($quoteTransfer->toArray());
-        $details = json_encode($paymentTransfer->getDetails() ?? []);
 
         $paymentData = $paymentTransfer->modifiedToArray();
         $paymentData[PaymentTransfer::QUOTE] = $quoteJson;
-        $paymentData[PaymentTransfer::DETAILS] = $details;
 
         return $spyPayment->fromArray($paymentData);
     }
@@ -37,7 +35,6 @@ public function mapPaymentEntityToPaymentTransfer(SpyPayment $spyPayment, Paymen
 
         $paymentData = $spyPayment->toArray();
         $paymentData[PaymentTransfer::QUOTE] = $quoteData;
-        $paymentData[PaymentTransfer::DETAILS] = $details;
 
         return $paymentTransfer->fromArray($paymentData, true);
     }
diff --git a/tests/_data/app_payment.databuilder.xml b/tests/_data/app_payment.databuilder.xml
index 58808ca..4f66a2f 100644
--- a/tests/_data/app_payment.databuilder.xml
+++ b/tests/_data/app_payment.databuilder.xml
@@ -9,7 +9,7 @@
     <transfer name="Payment" strict="true">
         <property name="redirectSuccessUrl" dataBuilderRule="url()"/>
         <property name="redirectCancelUrl" dataBuilderRule="url()"/>
-        <property name="details" dataBuilderRule="shuffle(array())"/>
+        <property name="details" dataBuilderRule="={}"/>
     </transfer>
 
     <transfer name="PaymentRefund" strict="true">

From 147e6015d49a84c3d77ec15edbde3de63a903d00 Mon Sep 17 00:00:00 2001
From: vol4onok <alexander.veselov@spryker.com>
Date: Tue, 23 Jul 2024 14:54:32 +0300
Subject: [PATCH 2/2] ACP-3468: Added additional payment data to payment entity

---
 .../Persistence/Propel/Payment/Mapper/PaymentMapper.php          | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/Spryker/Zed/AppPayment/Persistence/Propel/Payment/Mapper/PaymentMapper.php b/src/Spryker/Zed/AppPayment/Persistence/Propel/Payment/Mapper/PaymentMapper.php
index 37fbb2c..02ab4d0 100644
--- a/src/Spryker/Zed/AppPayment/Persistence/Propel/Payment/Mapper/PaymentMapper.php
+++ b/src/Spryker/Zed/AppPayment/Persistence/Propel/Payment/Mapper/PaymentMapper.php
@@ -31,7 +31,6 @@ public function mapPaymentTransferToPaymentEntity(PaymentTransfer $paymentTransf
     public function mapPaymentEntityToPaymentTransfer(SpyPayment $spyPayment, PaymentTransfer $paymentTransfer): PaymentTransfer
     {
         $quoteData = json_decode((string)$spyPayment->getQuote(), true);
-        $details = json_decode((string)$spyPayment->getDetails(), true);
 
         $paymentData = $spyPayment->toArray();
         $paymentData[PaymentTransfer::QUOTE] = $quoteData;