CommentingTrait is not working with phpstan/phpdoc-parser >= 1.18.1

[kfrohwein]

code-sniffer/Spryker/Traits/CommentingTrait.php

Line 40 in 55ae652

$constExprParser = new ConstExprParser();

https://github.com/phpstan/phpdoc-parser/blob/22dcdfd725ddf99583bfe398fc624ad6c5004a0f/src/Parser/ConstExprParser.php#L31

From Version 1.18.1 they added a constructor parameter that you are missing.
Please add a constrain to your composer file.
And make an updated version with minimum constrain to we can update to the later packages of phpstan.

[kfrohwein]

Thanks for the Patch! Please Spryker team update your trait! As this is a trait I cannot override it by injection on project level and we have to fork your module as dasann did!

[kfrohwein]

We did exclude basically all comment rules for now!

<rule ref="vendor/spryker/code-sniffer/Spryker/ruleset.xml"> <exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation"/> <exclude name="Spryker.Commenting.FullyQualifiedClassNameInDocBlock"/> <exclude name="Spryker.Commenting.DocBlockApiAnnotation"/> <exclude name="Spryker.Commenting.DocBlockConst"/> <exclude name="Spryker.Commenting.DocBlockInherit"/> <exclude name="Spryker.Commenting.DocBlockParamAllowDefaultValue"/> <exclude name="Spryker.Commenting.DocBlockParamArray"/> <exclude name="Spryker.Commenting.DocBlockParamNotJustNull"/> <exclude name="Spryker.Commenting.DocBlockParam"/> <exclude name="Spryker.Commenting.DocBlockReturnNullableType"/> <exclude name="Spryker.Commenting.DocBlockReturnNull"/> <exclude name="Spryker.Commenting.DocBlockReturnTag"/> <exclude name="Spryker.Commenting.DocBlockReturnVoid"/> <exclude name="Spryker.Commenting.DocBlock"/> <exclude name="Spryker.Commenting.DocBlockStructure"/> <exclude name="Spryker.Commenting.DocBlockTagGrouping"/> <exclude name="Spryker.Commenting.DocBlockTagIterable"/> <exclude name="Spryker.Commenting.DocBlockTagOrder"/> <exclude name="Spryker.Commenting.DocBlockTypeOrder"/> <exclude name="Spryker.Commenting.DocBlockVar"/> <exclude name="Spryker.Commenting.TypeHint"/> </rule>