Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent examples for Glue Resource Plugin implementation #1622

Open
VladyslavSikailo opened this issue Feb 14, 2023 · 0 comments
Open

Comments

@VladyslavSikailo
Copy link

On the page
https://docs.spryker.com/docs/scos/dev/glue-api-guides/202204.0/decoupled-glue-infrastructure/how-to-guides/routing/how-to-create-a-storefront-resource.html
it shows how to implement \Pyz\Glue\ModuleRestApi\Plugin\JsonConventionModuleResource

There are 2 problems with that:

  1. It implements JsonApiResourceInterface which is not present in any use section and doesn't exist in the codebase at all
  2. It conflicts with the approach that is used in the https://docs.spryker.com/docs/scos/dev/glue-api-guides/202204.0/glue-api-tutorials/implement-a-rest-api-resource.html#route-requests-to-your-controller for WishlistsResourceRoutePlugin

By the way the approach from second points implements \Spryker\Glue\GlueApplicationExtension\Dependency\Plugin\ResourceRoutePluginInterface so it's not clear what should I use.

Thanks

@VladyslavSikailo VladyslavSikailo changed the title Inconsistent for Glue Resource Plugin implementation Inconsistent examples for Glue Resource Plugin implementation Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant