Should SQLCIPHER_CFLAGS be optional or not?

[brody4hire]

It looks to me like SQLCIPHER_CFLAGS was documented as optional, but this changed in 310abc1

But it looks like this code still has some default C flags: https://github.com/sqlcipher/android-database-sqlcipher/blob/master/build.gradle#L88-L108

[developernotes]

Hi @brodybits,

You are correct, SQLCIPHER_CFLAGS is required for the build. I will remove the remnant default flags and in place provide an error message failing the build with the following message:

* What went wrong:
A problem occurred evaluating root project 'android-database-sqlcipher'.
> SQLCIPHER_CFLAGS environment variable must be specified and include at least '-DSQLITE_HAS_CODEC -DSQLITE_TEMP_STORE=2'

[brody4hire]

Was there a special reason for removing the default SQLCIPHER_CFLAGS?

It looked like a nice convenience to me.

[developernotes]

Hi @brodybits,

The intention is to favor explicitness in the build. We do not rely on the previous default values for other SQLCipher for Android builds.