Skip to content

Invalid MarkupKind in completion item documentation #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
valentinegb opened this issue Feb 28, 2025 · 0 comments · May be fixed by #176
Open

Invalid MarkupKind in completion item documentation #175

valentinegb opened this issue Feb 28, 2025 · 0 comments · May be fixed by #176

Comments

@valentinegb
Copy link

Describe the bug

The LSP specification says that MarkupKind should be either "plaintext" or "markdown", however it seems that sqls is sending "", which is invalid.

To Reproduce

Steps to reproduce the behavior:

  1. Open an SQL file
  2. Trigger autocomplete

Expected behavior

sqls is giving CompletionItems with the following:

{
  // ...
  "documentation": { "kind": "", "value": "" },
  // ...
},

It should probably not specify documentation at all in cases like this.

Versions (please complete the following information):

  • OS Version: macOS 15.4 Beta (24E5206s)
  • sqls Version: v0.2.27

Additional context

Example of erroneous response:

[
  {
    "label": "ABORT",
    "kind": 14,
    "detail": "keyword",
    "documentation": { "kind": "", "value": "" },
    "sortText": "9999ABORT"
  },
  {
    "label": "ACTION",
    "kind": 14,
    "detail": "keyword",
    "documentation": { "kind": "", "value": "" },
    "sortText": "9999ACTION"
  },
  {
    "label": "ADD",
    "kind": 14,
    "detail": "keyword",
    "documentation": { "kind": "", "value": "" },
    "sortText": "9999ADD"
  },
  {
    "label": "AFTER",
    "kind": 14,
    "detail": "keyword",
    "documentation": { "kind": "", "value": "" },
    "sortText": "9999AFTER"
  },
  // ...
]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: omit document key when empty camfowler/sqls
1 participant
@valentinegb