-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1247: WIP: Partial Tree Rerendering #1248
Draft
steve-the-edwards
wants to merge
2
commits into
main
Choose a base branch
from
sedwards/partial-tree
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+79
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a393b93
to
0514919
Compare
6f2d156
to
74fb6fb
Compare
0514919
to
7c724a3
Compare
74fb6fb
to
c7d7c15
Compare
06bf903
to
e1f220c
Compare
0a36563
to
717d484
Compare
7d7098f
to
b6e677c
Compare
return flow.value | ||
context.runningWorker(rerenderWorker) { output: T -> | ||
action("rerenderUpdate") { | ||
state = output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prior to this state was not actually changing - so this would not work in the optimized runtime.
8647d68
to
e99c6b6
Compare
717d484
to
646ebf7
Compare
3a5f35a
to
f888f1d
Compare
f888f1d
to
f04cb3d
Compare
Track whether or not the state (or state of a child) has changed in the WorkflowNode. Pass lastRendering if its not.
f04cb3d
to
2a074ea
Compare
2a074ea
to
b40368b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-render the node only if:
In order to do this, we have to propagate the action cascade all the way up to the root to record a single path of changed nodes.
Note we currently do not re-render if the workflow instance changed (unless the state also changed!), assuming the new workflow is still compatible with the old rendering because its identifier did not change.
Closes #1247.