Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I think we broke the name param to action() when fired from workers #391

Open
rjrjr opened this issue Mar 26, 2021 · 3 comments · Fixed by #1241
Open

I think we broke the name param to action() when fired from workers #391

rjrjr opened this issue Mar 26, 2021 · 3 comments · Fixed by #1241
Assignees
@rjrjr
Labels
logging

Comments

@rjrjr
Copy link
Contributor

rjrjr commented Mar 26, 2021

I'm giving my app logging of every WorkflowAction fired, via RenderContextInterceptor.onActionSent. I find that the toString() of an action fired by a Worker is prefixed sendAndAwaitApplication(com.squareup.workflow1.EmitWorkerOutputAction(worker=, and completely omits any name parameter provided to StatefulWorkflow.action() et al. Somewhere along the way with all this wrapping we've clobbered an important toString(), or failed to call it.
@rjrjr rjrjr self-assigned this Mar 26, 2021
@rjrjr
Copy link
Contributor Author

rjrjr commented Mar 26, 2021

The trail starts with the toString() override in Sink.sendAndAwaitApplication, com/squareup/workflow1/Sink.kt:84

@rjrjr
Copy link
Contributor Author

rjrjr commented Mar 26, 2021

And it ends at EmitWorkerOutputAction.toString, which has no visibility into the core action it's associated with.

@rjrjr rjrjr added the logging label Jun 24, 2021
@steve-the-edwards steve-the-edwards mentioned this issue Dec 13, 2024
Merged
@rjrjr rjrjr reopened this Dec 17, 2024
@rjrjr
Copy link
Contributor Author

rjrjr commented Dec 17, 2024

Accidentally closed by #1241, by a commit message explaining "this doesn't fix #391".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjrjr rjrjr

Labels
logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pipe Worker Output Action Names square/workflow-kotlin
1 participant
@rjrjr