Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need Completable.asWorker() solution when Worker.createSideEffect() is removed. #526

Closed
steve-the-edwards opened this issue Aug 25, 2021 · 2 comments
Closed

Need Completable.asWorker() solution when Worker.createSideEffect() is removed. #526

steve-the-edwards opened this issue Aug 25, 2021 · 2 comments

Comments

@steve-the-edwards
Copy link
Contributor

Completable, by definition is emitting Nothing. We can't handle that as a Worker and that is not needed because of runningSideEffect.

See #262
@steve-the-edwards
Copy link
Contributor Author

The solution is just not to use a Worker for Completable.

if you have

myCompletable: Completable
// use
context.runningSideEffect {
  myCompletable.await()
}

@steve-the-edwards
Copy link
Contributor Author

Closed by #1237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steve-the-edwards