Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial github action #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Initial github action #5

wants to merge 2 commits into from

Conversation

yadij
Copy link
Contributor

@yadij yadij commented Oct 12, 2022

The Squid code repository should not contain invasive
CI framework logic. That workflow file can use
actions defined in this repository for the heavy lifting.

Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I am against this specific action move because it introduces maintenance/comprehension overheads without enough gain and because it makes support for Squid-version-specific dependencies a lot more difficult/cumbersome, negating many of the benefits of an invasive CI configuration file. However, I do not plan on vetoing this PR on these grounds.

PR description: [Squid] workflow file can use actions defined in this repository

Action reuse is indeed possible, but, AFAICT, the changes in this PR do not create a reusable action. If you insist on moving this dependency installation code into a different repository, then please follow GitHub requirements for creating reusable actions. When you are done, please test reuse using your /squid and /ci repository clones on GitHub and share a pointer to that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants