fix: reserve var.name for togomak

srevinsaju · Nov 3, 2023 · b483c3a · b483c3a
1 parent a6abb4f
commit b483c3a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/internal/ci/module_run.go b/internal/ci/module_run.go
@@ -208,6 +208,7 @@ func (m *Module) run(conductor *Conductor, source string, evalCtx *hcl.EvalConte
 		} else {
 			expr = hcl.StaticExpr(v, attr.Expr.Range())
 		}
+		logger.Tracef("setting variable %s to %s", attr.Name, expr)
 		variable := &Variable{
 			Id:    attr.Name,
 			Value: expr,

diff --git a/internal/ci/variable_run.go b/internal/ci/variable_run.go
@@ -20,6 +20,16 @@ func (v *Variable) Prepare(conductor *Conductor, skip bool, overridden bool) hcl
 
 func (v *Variable) resolveVar(conductor *Conductor) (cty.Value, hcl.Diagnostics) {
 	var diags hcl.Diagnostics
+	if v.Id == "name" {
+		diags = diags.Append(&hcl.Diagnostic{
+			Severity:    hcl.DiagError,
+			Summary:     "Invalid variable name",
+			Detail:      fmt.Sprintf("The variable name '%s' has been reserved by togomak", v.Id),
+			EvalContext: conductor.Eval().Context(),
+		})
+		return cty.NilVal, diags
+	}
+
 	osEnvValue := os.Getenv(fmt.Sprintf("TOGOMAK_VAR_%s", v.Id))
 	if osEnvValue != "" {
 		return cty.StringVal(osEnvValue), nil