Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests not currently passing #26

Open
KyleMaas opened this issue Jan 15, 2021 · 5 comments
Open

Tests not currently passing #26

KyleMaas opened this issue Jan 15, 2021 · 5 comments

Comments

@KyleMaas
Copy link
Contributor

KyleMaas commented Jan 15, 2021 •
edited
Loading

Was trying to hunt down an issue and found that chloride's tests are not currently passing in the main branch.
@staltz
Copy link
Member

staltz commented Jan 15, 2021

How so? This is the latest commit on main: https://github.com/ssb-js/chloride/runs/1611479946

@KyleMaas
Copy link
Contributor Author

test-results-redacted.txt

Maybe I'm reading the output wrong, but I'm seeing a lot of "expected throw: Error: (something)" where in other tests it says PASSED. I would think the absence of PASSED and the presence of Error would indicate a problem. Here are the results I'm seeing, with working directory redacted.

@christianbundy
Copy link
Contributor

My memory: That's normal. This package doesn't use a normal test runner, see my comment in #22 .

@KyleMaas
Copy link
Contributor Author

Hm. That's unfortunate. Not at all clear.

@christianbundy
Copy link
Contributor

Yep. It's fixed in #21 fwiw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@staltz @christianbundy @KyleMaas