Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing of nulled log entries #270

Open
KyleMaas opened this issue Dec 20, 2022 · 0 comments
Open

Indexing of nulled log entries #270

KyleMaas opened this issue Dec 20, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@KyleMaas
Copy link
Contributor

See the failure in this test run while trying to track down #268:

https://github.com/ssbc/go-ssb/actions/runs/3744726663/jobs/6358410184#step:9:406

What that means is that, in the absence of anything to prevent race conditions between operations on the main log and operations on the indexes, the indexes need to be able to deal with messages which have already been nulled from the main log since messages may be nulled before all of the concurrent index processing is able to process all of the messages.

If we had some way to wait for all the indexes to catch up (see #251), then you could instead make nulling operations wait for indexes to catch up first. But in the absence of that, the indexes need to deal with this.

@decentral1se decentral1se added the bug Something isn't working label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants