Fix -Wall and -Wunused-packages in explicit-record-fields plugin (has…

…kell#3996) * Fix -Wall and -Wunused-packages in explicit-record-fields plugin * Don't remove -Wwarn=incomplete-record-updates --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
stable-haskell · Jan 20, 2024 · a57a0b3 · a57a0b3
1 parent 456a0eb
commit a57a0b3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/plugins/hls-explicit-record-fields-plugin/hls-explicit-record-fields-plugin.cabal b/plugins/hls-explicit-record-fields-plugin/hls-explicit-record-fields-plugin.cabal
@@ -25,16 +25,13 @@ flag pedantic
   manual:      True
 
 common warnings
-    ghc-options: -Wall
+    ghc-options: -Wall -Wunused-packages -Wincomplete-record-updates
 
 library
     import:           warnings
     exposed-modules:  Ide.Plugin.ExplicitFields
-    -- other-modules:
-    -- other-extensions:
     build-depends:
       , base                  >=4.12 && <5
-      , ghc
       , ghcide                == 2.6.0.0
       , hls-plugin-api        == 2.6.0.0
       , lsp
@@ -43,8 +40,6 @@ library
       , text
       , syb
       , transformers
-      , ghc-boot-th
-      , unordered-containers
       , containers
       , aeson
     hs-source-dirs:   src
@@ -57,8 +52,6 @@ library
 test-suite tests
     import:           warnings
     default-language: Haskell2010
-    -- other-modules:
-    -- other-extensions:
     type:             exitcode-stdio-1.0
     hs-source-dirs:   test
     main-is:          Main.hs
@@ -67,5 +60,4 @@ test-suite tests
       , filepath
       , text
       , hls-explicit-record-fields-plugin
-      , lsp-test
       , hls-test-utils
diff --git a/plugins/hls-explicit-record-fields-plugin/src/Ide/Plugin/ExplicitFields.hs b/plugins/hls-explicit-record-fields-plugin/src/Ide/Plugin/ExplicitFields.hs
@@ -40,6 +40,8 @@ import           Development.IDE.Core.RuleTypes   (TcModuleResult (..),
                                                    TypeCheck (..))
 import qualified Development.IDE.Core.Shake       as Shake
 import           Development.IDE.GHC.Compat       (HsConDetails (RecCon),
+                                                   HsExpansion (HsExpanded),
+                                                   HsExpr (XExpr),
                                                    HsRecFields (..), LPat,
                                                    Outputable, getLoc,
                                                    recDotDot, unLoc)
@@ -85,8 +87,6 @@ import           Language.LSP.Protocol.Types      (CodeAction (..),
                                                    WorkspaceEdit (WorkspaceEdit),
                                                    type (|?) (InL, InR))
 
-import           Development.IDE.GHC.Compat       (HsExpansion (HsExpanded),
-                                                   HsExpr (XExpr))
 
 data Log
   = LogShake Shake.Log