Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How hard would it be to adapt this abstraction to MySQL? #7

Open
jgoux opened this issue Apr 8, 2024 · 3 comments
Open

How hard would it be to adapt this abstraction to MySQL? #7

jgoux opened this issue Apr 8, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@jgoux
Copy link

jgoux commented Apr 8, 2024

Hey 👋 ,

I'm one of the developers who worked on https://github.com/snaplet/postgres-wasm, I'm super happy to see that our work helped and that you were able to pull this off to make it usable! I added a shoutout to this project in the README. 😍

I see that you wrote an entire network adapter for it which I suppose is at the emulator level, so I'm wondering how hard it would be to have MySQL running in the browser now.

Again, congrats, mad work!

@N2D4 N2D4 added the enhancement New feature or request label Apr 8, 2024
@N2D4
Copy link
Contributor

N2D4 commented Apr 8, 2024

Thanks for adding this to your README, very much appreciated! I haven't tried MySQL (or anything else but Postgres), but yes, it should be possible. The network stack is a minimal implementation of TCP and UDP, and anything that runs on those should theoretically work.

Do you guys have a specific use case in mind?

@jgoux
Copy link
Author

jgoux commented Apr 8, 2024

Do you guys have a specific use case in mind?

The main use case to me is integration/e2e tests with in-memory databases. But I guess a network adapter wouldn't be needed in a Node.js environment. 🤔

We already have SQLite and PostgreSQL now with your project and PGlite, so I guess MySQL will be the only missing one from the big 3. 😄

Anyway, I don't want to pollute your issues, so I'll close that. I joined your Discord. 👍

@jgoux jgoux closed this as completed Apr 8, 2024
@N2D4
Copy link
Contributor

N2D4 commented Apr 8, 2024

I think that's very valid. We don't use MySQL internally so we have no immediate need, but I'll reopen it to keep track, maybe someone else wants to give it a try :)

@N2D4 N2D4 reopened this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants