Skip to content

Commit c77c039

Browse files
Merge pull request #159 from stackkit/feature/PHP-8.4
Test package with PHP 8.4
2 parents 8a12aed + 37e4634 commit c77c039

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

.env.example

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ CI_CLOUD_TASKS_PROJECT_ID=
66
CI_CLOUD_TASKS_QUEUE=
77
CI_CLOUD_TASKS_LOCATION=
88
CI_CLOUD_TASKS_SERVICE_ACCOUNT_EMAIL=
9-
CI_SERVICE_ACCOUNT_JSON_KEY=
9+
CI_SERVICE_ACCOUNT_JSON_KEY_PATH=

.github/workflows/run-tests.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,13 @@ jobs:
6464
matrix:
6565
db: ['mysql', 'pgsql']
6666
payload:
67+
- { queue: 'github-actions-laravel10-php84', laravel: '10.*', php: '8.4', 'testbench': '8.*'}
6768
- { queue: 'github-actions-laravel10-php83', laravel: '10.*', php: '8.3', 'testbench': '8.*'}
6869
- { queue: 'github-actions-laravel10-php82', laravel: '10.*', php: '8.2', 'testbench': '8.*'}
6970
- { queue: 'github-actions-laravel10-php81', laravel: '10.*', php: '8.1', 'testbench': '8.*'}
7071
- { queue: 'github-actions-laravel11-php82', laravel: '11.*', php: '8.2', 'testbench': '9.*' }
71-
- { queue: 'github-actions-laravel12-php83', laravel: '11.*', php: '8.3', 'testbench': '9.*' }
72+
- { queue: 'github-actions-laravel11-php83', laravel: '11.*', php: '8.3', 'testbench': '9.*' }
73+
- { queue: 'github-actions-laravel11-php84', laravel: '11.*', php: '8.4', 'testbench': '9.*' }
7274

7375
name: PHP ${{ matrix.payload.php }} - Laravel ${{ matrix.payload.laravel }} - DB ${{ matrix.db }}
7476

@@ -114,4 +116,5 @@ jobs:
114116
CI_CLOUD_TASKS_CUSTOM_QUEUE: ${{ matrix.payload.queue }}
115117
run: |
116118
echo $CI_SERVICE_ACCOUNT_JSON_KEY > tests/Support/gcloud-key-valid.json
119+
touch .env
117120
vendor/bin/phpunit

app.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM serversideup/php:8.3-fpm
1+
FROM serversideup/php:8.4-fpm
22

33
USER root
44
RUN install-php-extensions bcmath

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ services:
77
- .env
88
volumes:
99
- .:/var/www/html
10-
- ${CI_SERVICE_ACCOUNT_JSON_KEY}:/var/www/html/tests/Support/gcloud-key-valid.json
10+
- ${CI_SERVICE_ACCOUNT_JSON_KEY_PATH-./tests/Support/gcloud-key-valid.json}:/var/www/html/tests/Support/gcloud-key-valid.json
1111
mysql:
1212
image: mysql:8
1313
ports:

tests/CloudTasksApiTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ protected function setUp(): void
2424
'CI_CLOUD_TASKS_QUEUE',
2525
'CI_CLOUD_TASKS_LOCATION',
2626
'CI_CLOUD_TASKS_SERVICE_ACCOUNT_EMAIL',
27-
'CI_SERVICE_ACCOUNT_JSON_KEY',
2827
];
2928

3029
foreach ($requiredEnvs as $env) {

0 commit comments

Comments
 (0)