Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the removal of LogUpAtRow #997

Open
slumber opened this issue Jan 21, 2025 · 0 comments
Open

Revert the removal of LogUpAtRow #997

slumber opened this issue Jan 21, 2025 · 0 comments

Comments

@slumber
Copy link

slumber commented Jan 21, 2025

A single component can only finalize one lookup after the refactoring into relation syntax.

However, this is a breaking change for circuits that have multiple lookups in a single component, which is useful for component embedding several circuits to allow sharing columns.

It's possible to upgrade to current stwo, however it removes the ability for concurrent trace generation, which makes a significant difference.

It would be helpful to have an ability to finalize different logups in a single eval_at_row

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant