Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearing fields in merge edits #903

Closed
peolic opened this issue Jan 10, 2025 · 0 comments · Fixed by #904
Closed

Clearing fields in merge edits #903

peolic opened this issue Jan 10, 2025 · 0 comments · Fixed by #904
Labels
help wanted Extra attention is needed

Comments

@peolic
Copy link
Contributor

peolic commented Jan 10, 2025 •
edited
Loading

It appears to be the same bug as #587, which was fixed #677,
only dealt with MODIFY edits. MERGE edits still have this bug.
Example: Merging Jayne into Jane [2025] and removing the disambiguation results in an merge without the change.
Probably affects other merge-able entities.

It's possible that the fix #677 can be simply applied to the merge functions.
@peolic peolic added the help wanted Extra attention is needed label Jan 10, 2025
@peolic peolic mentioned this issue Jan 10, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix clearing fields in merge edits peolic/stash-box
1 participant
@peolic