Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Update Default Supported Video Codecs - Hevc + MKV #5642

Open
trashkun1978 opened this issue Feb 2, 2025 · 3 comments
Open

[RFC] Update Default Supported Video Codecs - Hevc + MKV #5642

trashkun1978 opened this issue Feb 2, 2025 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@trashkun1978
Copy link

Hello,

I keep having transcoding delays when I tried to seek through my videos on my Pixel 7 Pro using Chrome. I seemed to have figured out that the issue stems from the default video codecs, currently H264 & H265. However, my videos are being transcoded and set to Hevc and the container is MKV. I assume H265 and Hevc should be interchangeable and in this case just a naming issue. However, the logic to determine if something is streamable looks for exactly x255 and Hevc separately. Additionally, stash checks if the video codec and container are compatible, which is fair, but one of those checks to see if MKV is a supported video codec (currently set to H264 & H265 ). This causes some unexpected behavior since MKV is not a codec but it is checked as it would be cause it the always failure and not check if Hevc and MKV are valid together.

I am not the most familiar with assisting with Git Repos so I didn't submit a PR. I also know that changing this could have a much broader impact due to the sheer different types of players that it could impact which may not support Hevc and MKV. However, due to H265 already being set as a default video codec I assume Hevc should be as well.

For the mean time, I think I should be able to build my own docker image with some of the changes I want and get by for now.

Finally, this hasn't been updated since the browser.go file was created back in April 2022. I’m not sure what other changes could be made but I believe Hevc should be made a default video codec at this point in time.

Enhancement Requests:

  1. Include Hevc as default Video Codec

Image

  1. Fix Check if MKV is valid Video Codec

Image

@trashkun1978 trashkun1978 added the help wanted Extra attention is needed label Feb 2, 2025
@feederbox826
Copy link
Contributor

Firefox doesn't support mkv https://bugzilla.mozilla.org/show_bug.cgi?id=1422891

@feederbox826
Copy link
Contributor

also HEVC and H265 are interchangeable, and stash just recogizes it as "H265", "hevc" will never actually be used

@DogmaDragon
Copy link
Collaborator

DogmaDragon commented Mar 2, 2025

Firefox doesn't support mkv bugzilla.mozilla.org/show_bug.cgi?id=1422891

I ran into the issue after moving from Vivaldi and it's infuriating. They seemed to be confused as to what people want. Instead of just allowing already working codec playback when used inside MKV container they argue against supporting new codec combinations that MKV can use...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants