-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.19.3 Support | Crash on Startup #92
Comments
I updated the crash report, as other mods I used were having issues, adding red herrings. |
Same here. I found that Minecraft has a lot of changes between 1.19.2 and 1.19.3. I’ve written a patch that make this mod compatible with MC1.19.3, but there is the v3 branch on this repo. It’s not a good idea to create a new PR, as I think the default (v2) branch would be marked as end-of-life at some point. So, I thought I would leave this comment while I’m here. On the other hand, this mod has a dependency with SoundCategories, and that also needs to be updated to 1.19.3 compatible. They are able to run on MC1.19.3. If you interested in, and great knowledge of Gradle and JDK, you can try to build.
For Non Developers If you just want to use ExtraSounds 1.19.3, it is available on my maven. But please note, it’s unofficial build and you use it entirely at your own risk.
https://artifactory.kow08absty.com/artifactory/fabricmc/dev/stashy/extra-sounds/2.3.1%2B1.19.3~lonefelidae16-build.4/extra-sounds-2.3.1%2B1.19.3~lonefelidae16-build.4.jar Changes For more details, please check my commit log.
|
@lonefelidae16 v3 is still pretty far away, I'm keeping v2 on maintenance until it's released - you can submit PRs to both projects if you wish, though I would very much appreciate splitting changes into separate PRs (e.g. necessary for 1.19.3, additional fixes, etc). Thanks for your contribution in advance :) |
@stashymane Hi, thank you for your comment. I see v3 is not coming for now. However... I’ve crammed a lot of changes into one commit, so I’m going to break it down and separate it into ”Porting”, ”Fix” and ”Enhancement”. When I’m ready, I’ll create new PRs for both projects. It’ll take some time. |
Tested with 1.19.4 works flawlessly! thanks a lot! |
Minecraft: 1.19.3 Fabric
Mod: Extra sounds(?)
Details
Can't run Extra Sounds on Fabric 1.19.3, crash log below:
The text was updated successfully, but these errors were encountered: